From 3652dc42a9258f1eabd06d4401ea6759bf50d56b Mon Sep 17 00:00:00 2001 From: dietmar63 Date: Fri, 21 Nov 2014 22:00:16 +0000 Subject: [PATCH] 98_WOL: logging improved git-svn-id: svn://svn.code.sf.net/p/fhem/code/trunk@7036 2b470e98-0d58-463d-a4d8-8e2adae1ed80 --- fhem/FHEM/98_WOL.pm | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/fhem/FHEM/98_WOL.pm b/fhem/FHEM/98_WOL.pm index 0a7f2b472..30973f8cf 100644 --- a/fhem/FHEM/98_WOL.pm +++ b/fhem/FHEM/98_WOL.pm @@ -120,7 +120,6 @@ sub WOL_Define($$) { RemoveInternalTimer($hash); WOL_UpdateReadings($hash); - WOL_GetUpdate ($hash); return undef; } ################################################################################ @@ -133,17 +132,28 @@ sub WOL_Undef($$) { } ################################################################################ sub WOL_UpdateReadings($) { + my ($hash) = @_; $hash->{INTERVAL} = AttrVal($hash->{NAME}, "interval", 900); - + + my $name = $hash->{NAME}; my $ip = $hash->{IP}; readingsBeginUpdate ($hash); - if (`ping -c 1 -w 2 $ip` =~ m/100%/) { + my $ping = "ping -c 1 -w 2 $ip"; + my $res = qx ($ping); + $res = "" if (!defined($res)); + + Log3 $hash, 5, "[$name] executing: $ping"; + Log3 $hash, 5, "[$name] result of ping:$res"; + + if ( $res =~ m/100%/) { + Log3 $hash, 5, "[$name] ping not succesful - state = on"; readingsBulkUpdate ($hash, "isRunning", "false"); readingsBulkUpdate ($hash, "state", "off"); } else { + Log3 $hash, 5, "[$name] ping succesful - state = on"; readingsBulkUpdate ($hash, "isRunning", "true"); readingsBulkUpdate ($hash, "state", "on"); }