From 48a83f0c60bf9559be6866e691eb9fb2ef8a9f66 Mon Sep 17 00:00:00 2001 From: DeeSPe Date: Wed, 3 Mar 2021 19:12:42 +0000 Subject: [PATCH] 98_serviced: fix update only after init_done git-svn-id: https://svn.fhem.de/fhem/trunk@23884 2b470e98-0d58-463d-a4d8-8e2adae1ed80 --- fhem/FHEM/98_serviced.pm | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/fhem/FHEM/98_serviced.pm b/fhem/FHEM/98_serviced.pm index d954c28bc..bcdceff22 100644 --- a/fhem/FHEM/98_serviced.pm +++ b/fhem/FHEM/98_serviced.pm @@ -77,11 +77,7 @@ sub serviced_Define($$) "StatusJammed=state,values=/error|failed/:JAMMED;/.*/:NOT_JAMMED"; } } - if ($init_done) - { - readingsSingleUpdate($hash,"state","Initialized",1) ; - serviced_GetUpdate($hash); - } + readingsSingleUpdate($hash,"state","Initialized",1) if ($init_done); return undef; } @@ -391,10 +387,10 @@ sub serviced_GetUpdate(@) { my ($hash) = @_; my $name = $hash->{NAME}; + RemoveInternalTimer($hash); + return if (IsDisabled($name) || !$init_done); my $sec = defined $hash->{helper}{interval} ? $hash->{helper}{interval} : AttrNum($name,"serviceStatusInterval",undef); delete $hash->{helper}{interval} if (defined $hash->{helper}{interval}); - RemoveInternalTimer($hash); - return if (IsDisabled($name)); serviced_Set($hash,$name,"status"); return if (!$sec); InternalTimer(gettimeofday() + $sec,"serviced_GetUpdate",$hash);