mhop/fhem
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

OWMULTI_BinValues: process only calles with expected readdata

Browse Source 
git-svn-id: svn://svn.code.sf.net/p/fhem/code/trunk@5436 2b470e98-0d58-463d-a4d8-8e2adae1ed80
This commit is contained in:
ntruchsess
2014-04-04 20:26:08 +00:00
parent de1175378f
commit c3b2b86055
1 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
fhem/FHEM/21_OWMULTI.pm
View File

@@ -747,17 +747,24 @@ sub OWXMULTI_BinValues($$$$$$$$) {
my ($hash, $context, $success, $reset, $owx_dev, $command, $numread, $res) = @_;
#-- always check for success, unused are reset, numread
return unless ($success and $context);
return unless ($success and $context =~ /^ds2438.getv[ad]d$/);
#Log 1,"OWXMULTI_BinValues context = $context";
#-- process results
my @data=split(//,$res);
Log 1, "invalid data length, ".int(@data)." instead of 9 bytes"
if (@data != 9);
Log 1, "conversion not complete or data invalid"
if ((ord($data[0]) & 112)!=0);
Log 1, "invalid CRC"
if (OWX_CRC8(substr($res,0,8),$data[8])==0);
if (@data != 9) {
Log 1, "invalid data length, ".int(@data)." instead of 9 bytes";
return;
}
if ((ord($data[0]) & 112)!=0) {
Log 1, "conversion not complete or data invalid";
return;
}
if (OWX_CRC8(substr($res,0,8),$data[8])==0) {
Log 1, "invalid CRC";
return;
}
#-- this must be different for the different device types
# family = 26 => DS2438